Fixed issue where wrong DB-connection was returned #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using multiple databases, the method get_pool_n_conn will give the wrong database connection at times due to the method don't return early, and any found connections can be overridden in the next iteration of the loop over the connection pool list. This fix makes the method get_pool_n_conn return early when a matching connection has been found.
patrikjohansson
force-pushed
the
handle_multiple_dbs
branch
from
463ae35 to
fcd13f4
Compare
shengxil
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple databases, the method get_pool_n_conn will
give the wrong database connection at times due to the method don't return early,
and any found connections can be overridden in the next iteration of the loop over the
connection pool list.
Description of changes:
This fix makes the method get_pool_n_conn return early when a matching
connection has been found.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.