Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for IMDSv2 #48

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Added support for IMDSv2 #48

merged 2 commits into from
Jun 10, 2020

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Jun 3, 2020

Issue #, if available:

Description of changes:

  • Fetching metadata from IMDSv2 with fallback to IMDSv1
  • Replaced open_uri with net/http since it only supports GET
  • Updated unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash requested a review from shengxil June 3, 2020 18:47
@srprash srprash requested a review from shengxil June 4, 2020 21:45
bhautikpip
bhautikpip approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@bhautikpip bhautikpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@srprash srprash merged commit 3148a68 into master Jun 10, 2020
@willarmiros willarmiros deleted the imdsv2_support branch November 10, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhautikpip bhautikpip bhautikpip approved these changes

@shengxil shengxil Awaiting requested review from shengxil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srprash @shengxil @bhautikpip