Add initial support for CORS #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has the default set of values that mirror what you get in the console. It does not yet set up an ``OPTIONS`` method for you.
It's probably worth refactoring this logic into a separate class, especially when support is added to configure exactly what CORS settings you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for CORS, and mimics what the enable CORS button does in the AWS Console.
This is the first item called out in #70 (comment)
The only chance from that comment was that I ended up creating a single arg called
corsinstead ofenable_cors. That way you can either enable cors viacors=True, or you can eventually provide a cors config to control exactly how you'd like cors enabled viacors=CORSConfig(...).Parts 2 and 3 of the spec will be sent as separate pull requests, and I'll likely need to refactor the internals a bit, but I wanted to get this initial version out before working on parts 2 and 3.