Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: maximum_concurrency option in on_sqs_message #2104

Conversation

adityamohta
Copy link
Contributor

Issue #2031

Description of changes:

This PR adds option to configure MaximumConcurrency value for sqs event source lambdas.

The option can be used like following:

@app.on_sqs_message(queue='my-queue', batch_size=1, maximum_concurrency=20)
def handle_sqs_message(event):
    ...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leobarcellos
Copy link

This is really useful.

@adityamohta
Copy link
Contributor Author

The test failure for python3.8 in ci seem unrelated to this PR.

@jamesls
Copy link
Member

jamesls commented May 30, 2024

Thanks for the pull request.

Yeah those py38 errors should be fixed in #2092, so rebasing from master should fix this. I can take a look at this tomorrow.

@adityamohta adityamohta force-pushed the aditya/add-maximum-concurrency-option-for-sqs-event-source-lambda branch from 67e604b to 075bd77 Compare May 30, 2024 01:40
@adityamohta
Copy link
Contributor Author

Yeah those py38 errors should be fixed in #2092, so rebasing from master should fix this. I can take a look at this tomorrow.

Ah, makes sense, thanks for sharing that @jamesls ! 🙇🏻‍♂️

@adityamohta
Copy link
Contributor Author

adityamohta commented Jun 3, 2024

I have manually tested the cloudformation, terraform output, and also the chalice deployer (which uses boto). All are working correctly.

@jamesls Thank you for the fix! Rebasing went fine.

Sorry to tag you directly, I understand that reviewing is time consuming, and it would be difficult to find out time for the same. If there is anything I could do to make the process easier let me know, I would be happy to add it here, as well as I will keep that in mind for the future PRs so reviewing is less painful.

Thank you for all the work you are doing to maintain this project. It's class 🙇

@jamesls
Copy link
Member

jamesls commented Jun 3, 2024

@adityamohta Thanks for updating, appreciate your work on this. Taking a look now.

Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, was playing around with the feature and everything's working as expected. Thanks again!

jamesls added a commit that referenced this pull request Jun 3, 2024
jamesls added a commit that referenced this pull request Jun 3, 2024
…rce-lambda'

PR #2104

* aditya/add-maximum-concurrency-option-for-sqs-event-source-lambda:
  Add changelog entry for #2104
  feat: sqs event source mapping - maximum_concurrency
@jamesls jamesls merged commit 075bd77 into aws:master Jun 3, 2024
15 checks passed
@adityamohta
Copy link
Contributor Author

Amazing! Thank you so much for taking out time to review @jamesls 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants