-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: maximum_concurrency option in on_sqs_message #2104
feat: maximum_concurrency option in on_sqs_message #2104
Conversation
This is really useful. |
The test failure for python3.8 in ci seem unrelated to this PR. |
Thanks for the pull request. Yeah those py38 errors should be fixed in #2092, so rebasing from master should fix this. I can take a look at this tomorrow. |
67e604b
to
075bd77
Compare
I have manually tested the cloudformation, terraform output, and also the chalice deployer (which uses boto). All are working correctly. @jamesls Thank you for the fix! Rebasing went fine. Sorry to tag you directly, I understand that reviewing is time consuming, and it would be difficult to find out time for the same. If there is anything I could do to make the process easier let me know, I would be happy to add it here, as well as I will keep that in mind for the future PRs so reviewing is less painful. Thank you for all the work you are doing to maintain this project. It's class 🙇 |
@adityamohta Thanks for updating, appreciate your work on this. Taking a look now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, was playing around with the feature and everything's working as expected. Thanks again!
Amazing! Thank you so much for taking out time to review @jamesls 🙇 |
Issue #2031
Description of changes:
This PR adds option to configure MaximumConcurrency value for sqs event source lambdas.
The option can be used like following:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.