Fix distutils warning when packaging/deploying apps #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If distutils is imported before pip outside of a `setup.py`, you see a deprecation warning about distutils. This was caused by a depdency we use, `inquirer`, using a dependency that used distutils. Upgrading to the latest major version of `inquirer` fixes this issue, which no longer depends on the affected package. As a result, we no longer see this warning message when running `chalice package` or `chalice deploy`. This triggered several other dependencies that needed to be updated, which resulted in a few cosmetic code tweaks to make pylint happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If distutils is imported before pip outside of a
setup.py, you see a deprecation warning about distutils. This warning was being triggered whenever you runchalice package/deploy:This was caused by a depdency we use,
inquirer, using a dependency that used distutils. Upgrading to the latest major version ofinquirerfixes this issue, which no longer depends on the affected package. As a result, we no longer see this warning message when runningchalice packageorchalice deploy.This triggered several other dependencies that needed to be updated, which resulted in a few cosmetic code tweaks to make pylint happy.