Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "fix: cannot create root construct in python" #2499

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: revert "fix: cannot create root construct in python" #2499

merged 3 commits into from
Oct 11, 2024

Conversation

kaizencc
Copy link
Contributor

Reverts #2496

Seeing failures in AWS CDK reading

warn - METHOD aws-cdk-lib.aws_workspacesweb.CfnPortal.createRoot: has been removed [removed:aws-cdk-lib.aws_workspacesweb.CfnPortal.createRoot]

@mrgrain mrgrain changed the title revert: "fix: cannot create root construct in python" fix: revert: "fix: cannot create root construct in python" Oct 11, 2024
mrgrain
mrgrain reviewed Oct 11, 2024
View reviewed changes
src/construct.ts Outdated Show resolved Hide resolved
mrgrain
mrgrain reviewed Oct 11, 2024
View reviewed changes
src/construct.ts Outdated Show resolved Hide resolved
@mrgrain mrgrain changed the title fix: revert: "fix: cannot create root construct in python" revert: "fix: cannot create root construct in python" Oct 11, 2024
@mrgrain mrgrain changed the title revert: "fix: cannot create root construct in python" fix: revert "fix: cannot create root construct in python" Oct 11, 2024
chore: self mutation
b20729e 
Signed-off-by: github-actions <github-actions@github.com>
@mergify mergify bot merged commit 3f6a73a into 10.x Oct 11, 2024
13 checks passed
@mergify mergify bot deleted the revert-2496-mrgrain/fix/python-root-construct branch October 11, 2024 19:22
mrgrain added a commit that referenced this pull request Oct 11, 2024
@mrgrain
fix: cannot create root construct in python
7c9289c 
The previous attempt in #2499 caused the static helper to be added to every construct, which was unintentional and caused side-effects. Instead export a class that does the same.

Fixes #1063
@mrgrain mrgrain mentioned this pull request Oct 11, 2024
Merged
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@mrgrain
fix: cannot create root construct in python (#2500)
892bb11 
The previous attempt in #2499 caused the static helper to be added to every construct, which was unintentional and caused side-effects. Instead export a class that does the same.

Fixes #1063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaizencc @mrgrain