-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement ask for secret init #2271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ask experience for this command! Just a few nit comments.
name, err := o.prompter.Get(secretInitSecretNamePrompt, | ||
secretInitSecretNamePromptHelp, | ||
validateSecretName, | ||
prompt.WithFinalMessage("secret name: ")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Co-authored-by: Penghao He <penghaoh@amazon.com>
…to secret/cli-ask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Good unit test coverage! Just some tiny nits; go ahead and remove the do-not-merge label when you've addressed them.
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
…to secret/cli-ask
This PR calls ssm package and put secret from secret init. Next step: parse secret input file. Preceding PR: #2271 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This PR calls ssm package and put secret from secret init. Next step: parse secret input file. Preceding PR: aws#2271 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This PR calls ssm package and put secret from secret init. Next step: parse secret input file. Preceding PR: #2271 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Proceeding PR: aws#2266 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This PR calls ssm package and put secret from secret init. Next step: parse secret input file. Preceding PR: aws#2271 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Proceeding PR: #2266
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.