Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement ask for secret init #2271

Merged
merged 10 commits into from
May 7, 2021
Merged

Conversation

Lou1415926
Copy link
Contributor

Proceeding PR: #2266

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Lou1415926 Lou1415926 requested a review from a team as a code owner May 5, 2021 23:00
@Lou1415926 Lou1415926 requested a review from bvtujo May 5, 2021 23:00
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ask experience for this command! Just a few nit comments.

name, err := o.prompter.Get(secretInitSecretNamePrompt,
secretInitSecretNamePromptHelp,
validateSecretName,
prompt.WithFinalMessage("secret name: "))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it :shipit:

@huanjani huanjani added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label May 7, 2021
Copy link
Contributor

@huanjani huanjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Good unit test coverage! Just some tiny nits; go ahead and remove the do-not-merge label when you've addressed them.

Lou1415926 and others added 4 commits May 7, 2021 12:53
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
Co-authored-by: Janice Huang <60631893+huanjani@users.noreply.github.com>
@Lou1415926 Lou1415926 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label May 7, 2021
@mergify mergify bot merged commit c585dfa into aws:mainline May 7, 2021
mergify bot pushed a commit that referenced this pull request May 11, 2021
This PR calls ssm package and put secret from secret init.

Next step: parse secret input file.

Preceding PR: #2271 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
patnolanireland pushed a commit to patnolanireland/copilot-cli that referenced this pull request May 12, 2021
This PR calls ssm package and put secret from secret init.

Next step: parse secret input file.

Preceding PR: aws#2271 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
efekarakus pushed a commit that referenced this pull request May 12, 2021
This PR calls ssm package and put secret from secret init.

Next step: parse secret input file.

Preceding PR: #2271 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
Proceeding PR: aws#2266 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
This PR calls ssm package and put secret from secret init.

Next step: parse secret input file.

Preceding PR: aws#2271 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants