fix: Initialize EnvDescriber in init command for svc and job #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KollaAdithya
requested review from
dannyrandall
and removed request for
a team
iamhopaul123
approved these changes
Dec 6, 2022
huanjani
reviewed
Dec 6, 2022
| ConfigStore: configStore, | ||
| }) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("initiate env describer: %w", err) |
There was a problem hiding this comment.
nit (here and below):
"initialize" instead of "initiate"?
nvm "initiate" is all over our codebase
huanjani
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the failing test suite i.e, to initialize EnvDescriber for both service and job in init
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.