feat!: run local --use-task-role flag
#5529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 13, 2023 15:53
CaptainCarpensir
requested review from
KollaAdithya
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## mainline #5529 +/- ##
============================================
- Coverage 70.05% 70.01% -0.04%
============================================
Files 302 302
Lines 46293 46403 +110
Branches 301 301
============================================
+ Hits 32429 32490 +61
- Misses 12291 12335 +44
- Partials 1573 1578 +5 ☔ View full report in Codecov by Sentry. |
|
🍕 Here are the new binary sizes!
|
iamhopaul123
approved these changes
Dec 6, 2023
CaptainCarpensir
changed the title
--use-task-role flag--use-task-role flag
added 3 commits
December 7, 2023 14:42
CaptainCarpensir
changed the title
--use-task-role flag
iamhopaul123
added
do-not-merge
CaptainCarpensir
changed the title
--use-task-role flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the second method of retrieving the task role in the credentials chain:
ecs execBreaking change:
The
--use-task-roleflag will default totrue. This is a breaking change because in the event that neither method of receiving credentials works,copilot run localwill fail by default. To mitigate this, we introduce a recommended action displayed when--use-task-rolefails that gives the user 2 recommendations to proceed:copilot run local --use-task-role=falseto disable the feature.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.