Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responseTime should respect import ALB #5564

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

iamhopaul123
Copy link
Contributor

Fixes #5557

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner December 15, 2023 18:11
@iamhopaul123 iamhopaul123 requested review from dannyrandall and removed request for a team December 15, 2023 18:11
Copy link

github-actions bot commented Dec 15, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56976 56796 +0.32
macOS (arm) 58000 57796 +0.35
linux (amd) 49960 49804 +0.31
linux (arm) 49280 49092 +0.38
windows (amd) 47084 46940 +0.31

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bc5f46) 70.00% compared to head (e44a980) 70.00%.
Report is 2 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5564      +/-   ##
============================================
- Coverage     70.00%   70.00%   -0.01%     
============================================
  Files           302      302              
  Lines         46403    46403              
  Branches        301      301              
============================================
- Hits          32486    32484       -2     
- Misses        12338    12339       +1     
- Partials       1579     1580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit a2c99e0 into aws:mainline Dec 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Updating hosting from count: 1 to a load balanced configuration doesn't work with http.alb
4 participants