Fix krb ticket renewal in non domainjoined mode #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smhmhmd
reviewed
May 12, 2023
smhmhmd
reviewed
May 12, 2023
Validated the renewal flow with non-domain mode Added logic to store the the domainless user in the cache Testing: 1. Run the credentials fetcher daemon as ./credentials-fetcherd --aws_sm_secret_name "ADuser" 2. Create a kerberos ticket using ./gmsa_test_client --create 3. Wait for renewal to start ensure the ticket is renewed 4. Invoke the credentials-fetcher client ./gmsa_test_client --renew-non-domainjoined-lease "username" "password" "domain"
saikiranakula-amzn
force-pushed
the
kube_ticket_creation
branch
from
37d96ec
to
86823cb
Compare
saikiranakula-amzn
changed the title
smhmhmd
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix krb ticket renewal in non domainjoined mode
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.