Changed CMAKE_CXX_FLAGS to c++17, add target links to Abseil library and c_str() addition when logging #64
Conversation
CMakeLists link and path changes
Added include paths for x86_64-linux-gnu and resolving for absl lib
|
Thank you for your contribution! We will review your changes and get back to you as soon as possible |
* Changes in CMakeLists.txt with check for Ubuntu * Detect location of .NET for Ubuntu
Conditional compilation for Ubuntu
If libraries are not available, compile grpc and krb5 libs and include
into credentials-fetcher.
grpc and krb5 libs are separate CMake targets.
The grpc and krb5 tar files are too large for github, they have to be downloaded.
To build grpc or krb5:
* "cd dependencies && mkdir build && cd build && make build_grpc && make build_krb5"
Pull in grpc and krb5 compilation into credentials-fetcher
|
@saikiranakula-amzn - Please review PR |
|
@smhmhmd I just tried running cmake -DCMAKE_CXX_STANDARD=17 ../ on Ubuntu 20.04 and have now since received a number of errors. I will follow up with an output of the errors today ,but performing a cmake on the PR will repo the issue in Ubuntu |
Hi @fordth , I just retested in my instance. |
|
@fordth, I have some time till the end of the hour if you want to meet or we can meet on Monday. |
|
@fordth |
|
We plan to test the compilation morning of Wednesday 9/13. Once this PR is then completed, I will create a new PR containing the additional changes we spoke about. I will provide an update tomorrow |
Changing grpc install to default location from user defined directory since Cmake module in grpc searches only in default locations
Changing grpc install to default location from user defined directory since Cmake module in grpc searches only in default locations This also includes docker changes to build on Ubuntu-20.04
Contains docker file for Ubuntu 20.04 to support the latest CMake refactoring
|
Good catch, I updated the PR
…On Tue, Sep 19, 2023 at 1:46 PM Ram Chennuru ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docker/Dockerfile-ubuntu-22.04
<#64 (comment)>
:
> + && apt install -y git clang wget cmake curl \
+ libglib2.0-dev libboost-dev libkrb5-dev libsystemd-dev libssl-dev \
+ libboost-program-options-dev libboost-filesystem-dev
+
+RUN cd /root && git clone --recurse-submodules https://github.com/grpc/grpc \
+ && cd grpc/ \
+ && mkdir build \
+ && cd build \
+ && cmake -DgRPC_INSTALL=ON -DgRPC_BUILD_TESTS=OFF -DCMAKE_CXX_STANDARD=17 ../ \
+ && make -j4 \
+ && make install
+
+RUN apt-get update \
+ && apt-get install -y dotnet-sdk-6.0
+
+RUN cd /root && git clone https://github.com/fordth/credentials-fetcher \
Should we change the URL to point to correct branch?
—
Reply to this email directly, view it on GitHub
<#64 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNAMAAQR65DUMMKTXRUXEDX3HLABANCNFSM6AAAAAA4GNCL2A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…wnloads. Fixed issue with .net now included in Ubuntu 22.04 causing conflicts when installing .Net sdk 6 package.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.