-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HuggingFace PT Inference/training CVE fix #3523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-deep-learning-containers-ci
bot
added
build
Reflects file change in build folder
huggingface
Reflects file change in huggingface folder
Size:XS
Determines the size of the PR
labels
Nov 14, 2023
aws-deep-learning-containers-ci
bot
added
the
Size:S
Determines the size of the PR
label
Nov 15, 2023
haixiw
changed the title
HuggingFace Inference CVE fix
HuggingFace PT training/Inference CVE fix
Nov 15, 2023
haixiw
changed the title
HuggingFace PT training/Inference CVE fix
HuggingFace PT Inference CVE fix
Nov 19, 2023
This reverts commit e61eabb.
haixiw
changed the title
HuggingFace PT Inference CVE fix
HuggingFace PT Inference/training CVE fix
Nov 21, 2023
amzn-choeric
approved these changes
Nov 22, 2023
shantanutrip
approved these changes
Nov 22, 2023
chrstfu
approved these changes
Nov 24, 2023
chrstfu
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, I believe we need to change the release yaml to release the images?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Reflects file change in build folder
huggingface
Reflects file change in huggingface folder
Size:S
Determines the size of the PR
Size:XS
Determines the size of the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue #, if available:
Note:
If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.
All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.
Description
Fixing CVES for Huggingface pytorch inference images
Tests run
NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"
NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:
sagemaker_remote_tests = "standard"
sagemaker_remote_tests = "rc"
sagemaker_remote_tests = "efa"
All tests passed in the commit : 2716276
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.