Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch][Inference][EC2] Enable PT2.5.1 Autopatch #4421

Merged
merged 8 commits into from
Nov 15, 2024
Merged

[PyTorch][Inference][EC2] Enable PT2.5.1 Autopatch #4421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c180c38
add core packages
Nov 13, 2024
6ac56f5
add captum in core package
Nov 14, 2024
7f12b47
enable sm autopatch
Nov 14, 2024
010fd40
revert toml
Nov 14, 2024
c9c8ba6
Merge branch 'master' into autopatch
Yadan-Wei Nov 14, 2024
0d78bd5
Merge branch 'master' into autopatch
Yadan-Wei Nov 14, 2024
1091b7b
add requests to core packages
Nov 14, 2024
47c9689
change version to 2.32.3
Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pytorch/inference/buildspec-2-5-ec2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ framework: &FRAMEWORK pytorch
version: &VERSION 2.5.1
short_version: &SHORT_VERSION "2.5"
arch_type: x86
# autopatch_build: "True"
autopatch_build: "True"

repository_info:
inference_repository: &INFERENCE_REPOSITORY
Expand Down
2 changes: 1 addition & 1 deletion pytorch/inference/buildspec-2-5-sm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ framework: &FRAMEWORK pytorch
version: &VERSION 2.5.1
short_version: &SHORT_VERSION "2.5"
arch_type: x86
# autopatch_build: "True"
autopatch_build: "True"

repository_info:
inference_repository: &INFERENCE_REPOSITORY
Expand Down
2 changes: 1 addition & 1 deletion pytorch/inference/buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
buildspec_pointer: buildspec-2-5-ec2.yml
buildspec_pointer: buildspec-2-5-sm.yml
27 changes: 27 additions & 0 deletions pytorch/inference/docker/2.5/py3/Dockerfile.ec2.cpu.core_packages.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to pin requests>=2.23.3. CPU, GPU

Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"captum": {
"version_specifier": "==0.6.0",
"skip": "True"
},
"torchaudio": {
"version_specifier": "==2.5.1+cpu",
"skip": "True"
},
"torchtext": {
"version_specifier": "==0.18.0+cpu",
"skip": "True"
},
"torchvision": {
"version_specifier": "==0.20.1+cpu",
"skip": "True"
},
"torchserve": {
"version_specifier": "==0.12.0"
},
"requests": {
"version_specifier": ">=2.32.3"
},
"torch-model-archiver": {
"version_specifier": "==0.12.0"
}
}
30 changes: 30 additions & 0 deletions pytorch/inference/docker/2.5/py3/Dockerfile.sagemaker.cpu.core_packages.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to pin requests>=2.23.3. CPU, GPU

Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"captum": {
"version_specifier": "==0.6.0",
"skip": "True"
},
"torchaudio": {
"version_specifier": "==2.5.1+cpu",
"skip": "True"
},
"torchtext": {
"version_specifier": "==0.18.0+cpu",
"skip": "True"
},
"torchvision": {
"version_specifier": "==0.20.1+cpu",
"skip": "True"
},
"requests": {
"version_specifier": ">=2.32.3"
},
"torchserve": {
"version_specifier": "==0.12.0"
},
"torch-model-archiver": {
"version_specifier": "==0.12.0"
},
"sagemaker-pytorch-inference": {
"version_specifier": "==2.0.25"
}
}
27 changes: 27 additions & 0 deletions pytorch/inference/docker/2.5/py3/cu124/Dockerfile.ec2.gpu.core_packages.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to pin requests>=2.23.3. CPU, GPU

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CPU and GPU files, actually there is no vuln when I removed this version pin, I keep it there is because Sally suggests it doesn't matter to have it with the vuln number in the comments. In this situation, should I still add it as core package?

Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"captum": {
"version_specifier": "==0.6.0",
"skip": "True"
},
"torchaudio": {
"version_specifier": "==2.5.1+cu124",
"skip": "True"
},
"torchtext": {
"version_specifier": "==0.18.0+cu124",
"skip": "True"
},
"torchvision": {
"version_specifier": "==0.20.1+cu124",
"skip": "True"
},
"requests": {
"version_specifier": ">=2.32.3"
},
"torchserve": {
"version_specifier": "==0.12.0"
},
"torch-model-archiver": {
"version_specifier": "==0.12.0"
}
}
30 changes: 30 additions & 0 deletions pytorch/inference/docker/2.5/py3/cu124/Dockerfile.sagemaker.gpu.core_packages.json
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you forgot to pin requests>=2.23.3. CPU, GPU

Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"captum": {
"version_specifier": "==0.6.0",
"skip": "True"
},
"torchaudio": {
"version_specifier": "==2.5.1+cu124",
"skip": "True"
},
"torchtext": {
"version_specifier": "==0.18.0+cu124",
"skip": "True"
},
"torchvision": {
"version_specifier": "==0.20.1+cu124",
"skip": "True"
},
"requests": {
"version_specifier": ">=2.32.3"
},
"torchserve": {
"version_specifier": "==0.12.0"
},
"torch-model-archiver": {
"version_specifier": "==0.12.0"
},
"sagemaker-pytorch-inference": {
"version_specifier": "==2.0.25"
}
}
Loading