Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the package controller a package #831

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

lewisdiamond
Copy link
Member

@lewisdiamond lewisdiamond commented Feb 22, 2023

Description of changes:
Helm chart changes for package controller as a package. This removes the CRDs from the main package meaning this will break installation with the current CLI. The CLI must be updated once this is available.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

For documentation on how to upgrade, see https://anywhere.eks.amazonaws.com/docs/tasks/packages/#upgrade-the-packages-controller

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdiamond

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added approved size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2023
@lewisdiamond
Copy link
Member Author

/hold
I want to test keeping the CRDs in the main chart temporarily.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2023
@lewisdiamond
Copy link
Member Author

/unhold Keeping the CRDs in, this makes the new chart compatible with the current docs/flow and means we have no CLI changes required outside of the namespace move and create-namespace flag.

namespace: {{ .Values.namespace }}
name: pre-hook-cfg
annotations:
"helm.sh/hook": pre-install,pre-upgrade
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to make this pre-install only unless someone can come up with a situation where this would have to run on an upgrade.

@lewisdiamond
Copy link
Member Author

/unhold

metadata:
annotations:
"helm.sh/resource-policy": keep
name: eks-anywhere-packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So moving the namespace to the CRDs would make it so upgrading itself wouldn't fail right?

@jonahjon
Copy link
Contributor

/lgtm

@eks-distro-bot eks-distro-bot merged commit 16f7efc into aws:main Feb 24, 2023
ewollesen pushed a commit to ewollesen/eks-anywhere-packages that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants