-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the package controller a package #831
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdiamond The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
766a82e
to
001ce17
Compare
/hold |
5a4b876
to
a62ce45
Compare
/unhold Keeping the CRDs in, this makes the new chart compatible with the current docs/flow and means we have no CLI changes required outside of the namespace move and create-namespace flag. |
namespace: {{ .Values.namespace }} | ||
name: pre-hook-cfg | ||
annotations: | ||
"helm.sh/hook": pre-install,pre-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Planning to make this pre-install
only unless someone can come up with a situation where this would have to run on an upgrade.
a62ce45
to
2c16887
Compare
ce7390e
to
52dff0b
Compare
/unhold |
metadata: | ||
annotations: | ||
"helm.sh/resource-policy": keep | ||
name: eks-anywhere-packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So moving the namespace to the CRDs would make it so upgrading itself wouldn't fail right?
/lgtm |
This reverts commit 16f7efc.
Description of changes:
Helm chart changes for package controller as a package. This removes the CRDs from the main package meaning this will break installation with the current CLI. The CLI must be updated once this is available.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
For documentation on how to upgrade, see https://anywhere.eks.amazonaws.com/docs/tasks/packages/#upgrade-the-packages-controller