-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth agnostic kube client #1941
Conversation
Skipping CI for Draft Pull Request. |
216eebc
to
af4825f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1941 +/- ##
==========================================
+ Coverage 50.01% 50.07% +0.06%
==========================================
Files 290 293 +3
Lines 24680 24731 +51
==========================================
+ Hits 12343 12385 +42
- Misses 11040 11046 +6
- Partials 1297 1300 +3
Continue to review full report at Codecov.
|
932fa88
to
2fd1232
Compare
/lgtm |
Wrapping around the the kubectl interface to make the client API agnostic from the authentication mechanism. Also adding support for an internal schema that avoids having to indicate the resource type because it's inferred from the concrete CRD type. This allows to provide a common interface that can be implemented by both a kubectl binary wrapper and a controller runtime client. With this, we will be be able to build logic that interacts with the api server and that can be shared between the CLI and the controller.
bc31a18
to
8f73688
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #1106 and #1109
Description of changes
Wrapping around the the kubectl interface to make the client API
agnostic from the authentication mechanism. Also adding support for an
internal schema that avoids having to indicate the resource type because
it's inferred from the concrete CRD type.
This allows to provide a common interface that can be implemented by
both a kubectl binary wrapper and a controller runtime client. With
this, we will be be able to build logic that interacts with the api
server and that can be shared between the CLI and the controller.
Testing
Added unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.