Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete method to kube client #1990

Merged
merged 1 commit into from
May 3, 2022

Conversation

g-gaston
Copy link
Member

Part of #1106, needed only in snow cli provider and not in the controller for now

Testing (if applicable):
Uni tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@g-gaston g-gaston requested a review from jiayiwang7 April 30, 2022 08:29
@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2022
@g-gaston g-gaston force-pushed the unauth-client-delete branch from 3df1e6f to 823e536 Compare April 30, 2022 08:33
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #1990 (da52b4a) into main (71fae6a) will increase coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   50.11%   50.13%   +0.01%     
==========================================
  Files         295      295              
  Lines       24907    24923      +16     
==========================================
+ Hits        12481    12494      +13     
- Misses      11122    11124       +2     
- Partials     1304     1305       +1     
Impacted Files Coverage Δ
pkg/executables/kubectl.go 35.87% <40.00%> (+0.01%) ⬆️
pkg/clients/kubernetes/unauth.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71fae6a...da52b4a. Read the comment docs.

@jiayiwang7
Copy link
Member

should we have a method func (c *KubeconfigClient) Delete(ctx context.Context, name, namespace string, obj runtime.Object) error in kubeconfig.go?

@g-gaston
Copy link
Member Author

g-gaston commented May 3, 2022

should we have a method func (c *KubeconfigClient) Delete(ctx context.Context, name, namespace string, obj runtime.Object) error in kubeconfig.go?

Unless I'm missing something, the delete functionality is only needed at the provider level and not at the "templater" level. So we could add it, but I don't think we need it yet.

@g-gaston g-gaston force-pushed the unauth-client-delete branch from 823e536 to da52b4a Compare May 3, 2022 14:48
@jiayiwang7
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit d00c3db into aws:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants