Add code for EKS-A CLI, tests and release tooling #2
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test eks-anywhere-presubmit |
|
For the docs presubmit, I think you could change v0.5.0 to main to make that work |
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the aws org. You can then trigger verification by writing
|
|
@abhay-krishna: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sync from eks-anywhere repo
Merge upstream
* Support Cloudstack multiple endpoint for preflight checks * Update for review comments * Fix unit test failures * Remove debug print * Remove unnecessary file * Remove multierror module * Update to use single cmk object instead of list or map of multiple cmks * Remove ValidateCloudStackConnection when cleaning up VMs * Remove NewProviderCustomNet because it's the same as NewProvider * Avoid using 'failed to' in errors * Remove localAvailabilityZones from Validator * Remove multipleZone from ValidateNetworkPresent * Return list of errors CleanUpCloudstackTestResources * Increase unit test coverage * Increase unit test coverage #2 * Change error format * Change function names to be more descriptive - ValidateZonePresent -> ValidateZoneAndGetId - ValidateDomainPresent -> ValidateDomainAndGetId Change return value of ValidateDomainAndGetId - from CloudStackResourceIdentifier to string because only domainId is used * Add default verifySslValue as a constant * Fix a bug where empty Zone IDs are used in validateMachineConfig * Add error message when validating management api endpoint fails * Make MarkPass message more readable * Fix presubmit job failure
Adding code for
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.