Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetupAndValidateUpgradeCluster, UpgradeNeeded for snow #2006

Merged
merged 1 commit into from
May 4, 2022

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

#1106

Description of changes:

Add set defaults and validation step for snow. Compare snow eks-a and bundle resources to see if provider upgrade is needed.

Testing (if applicable):

unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jiayiwang7 jiayiwang7 requested a review from g-gaston May 4, 2022 16:24
@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2006 (67aeca3) into main (7ec067a) will increase coverage by 0.00%.
The diff coverage is 86.36%.

@@           Coverage Diff           @@
##             main    #2006   +/-   ##
=======================================
  Coverage   49.76%   49.77%           
=======================================
  Files         298      298           
  Lines       25406    25443   +37     
=======================================
+ Hits        12644    12664   +20     
- Misses      11444    11460   +16     
- Partials     1318     1319    +1     
Impacted Files Coverage Δ
pkg/providers/snow/snow.go 57.44% <86.36%> (+7.44%) ⬆️
internal/pkg/api/flux.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec067a...67aeca3. Read the comment docs.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit bd1c466 into aws:main May 4, 2022
@jiayiwang7 jiayiwang7 deleted the snow-upgradecmd branch May 4, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants