Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tinkerbell ci test harness to e2e test framework #2031

Merged
merged 27 commits into from
Jun 17, 2022

Conversation

gwesterfieldjr
Copy link
Contributor

@gwesterfieldjr gwesterfieldjr commented May 5, 2022

Update e2e test framework for tinkerbell CI

  • Enable ability to run e2e tests from a vSphere vm
  • Route all tinkerbell tests to vSphere
  • Split tinkerbell tests into test runner suites by hardware count (4). This is not most efficient way to split the hardware, but it will do for now. Post GA I will update this to a better reservation system.
  • Provision test runner instance to run tinkerbell tests
  • Update test framework to account for multiple tests running from single test runner instance
  • Update code build job file with required tinkerbell env vars
  • Update test power actions to bmc lib rather than pbnj
  • Clean up tests no longer needed post beta

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2031 (2392e39) into main (f454a4a) will decrease coverage by 0.22%.
The diff coverage is 13.33%.

@@            Coverage Diff             @@
##             main    #2031      +/-   ##
==========================================
- Coverage   56.92%   56.70%   -0.23%     
==========================================
  Files         306      306              
  Lines       24866    24978     +112     
==========================================
+ Hits        14155    14163       +8     
- Misses       9410     9499      +89     
- Partials     1301     1316      +15     
Impacted Files Coverage Δ
internal/pkg/api/hardware.go 0.00% <0.00%> (ø)
internal/pkg/api/tinkerbell.go 0.00% <0.00%> (ø)
pkg/providers/tinkerbell/hardware/yaml.go 52.00% <0.00%> (-4.53%) ⬇️
pkg/executables/govc.go 58.64% <57.14%> (-0.21%) ⬇️
pkg/providers/tinkerbell/hardware/machine.go 75.00% <100.00%> (+1.19%) ⬆️
pkg/providers/tinkerbell/assert.go 77.77% <0.00%> (-17.82%) ⬇️
pkg/providers/tinkerbell/validate.go 78.51% <0.00%> (-8.99%) ⬇️
pkg/providers/tinkerbell/template.go 28.36% <0.00%> (-4.10%) ⬇️
pkg/providers/tinkerbell/tinkerbell.go 34.93% <0.00%> (-3.43%) ⬇️
pkg/providers/tinkerbell/create.go 49.26% <0.00%> (-0.74%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f454a4a...2392e39. Read the comment docs.

@gwesterfieldjr gwesterfieldjr force-pushed the tink-ci branch 2 times, most recently from e22d964 to 1e8dcbc Compare May 10, 2022 15:15
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@gwesterfieldjr gwesterfieldjr force-pushed the tink-ci branch 5 times, most recently from aca6f63 to f42d1b1 Compare May 16, 2022 20:42
@gwesterfieldjr gwesterfieldjr force-pushed the tink-ci branch 5 times, most recently from ff564b7 to 6870f64 Compare June 2, 2022 19:57
@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 3, 2022
@gwesterfieldjr gwesterfieldjr force-pushed the tink-ci branch 6 times, most recently from 8f7d22d to e84c503 Compare June 7, 2022 17:50
@gwesterfieldjr gwesterfieldjr marked this pull request as ready for review June 7, 2022 17:55
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from abhinavmpandey08 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danbudris
Copy link
Member

/lgtm

@gwesterfieldjr
Copy link
Contributor Author

/approved

@gwesterfieldjr gwesterfieldjr merged commit 8fbcd59 into aws:main Jun 17, 2022
wongni pushed a commit to wongni/eks-anywhere that referenced this pull request Jun 21, 2022
* add tinkerbell ci test harness to e2e test framework

* split tink tests into instance suites based on hardware capacity

* account for multiple tests in single instance

decomm test runner

* fix generate hardware & marshall labels

* provision tink boostrap and server ip for ci

* update codebuild job for tinkerbell ci

* fix linter

* add kube 1.23 test

* account for future tinkerbell boostrap ip arg during create cluster cmd

* remove tink feature flag enable

* add option to override the local tinkerbell IP in the bootstrap cluster

* update tests for bootstrap flag

* update to lab vcenter

* update max cluster name length and power off hardware prior to each test

* add br test for tink

* enable k8 1.23 test for tink

* update conformance and prow tests to accound for tinkerbell changes

* split tink and cp cidr ranges

* persist vm on failure for debug

* fix bundle upload

* update tink conformance tests

* remove example infra config

* skip three worker test

* add ping test to show connectivity to vcenter in colo lab thru direct connect

* remove ping

* only run tink tests on main branch

* update test concurrent count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants