Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for snow workload cluster creation #2225

Merged
merged 1 commit into from
May 24, 2022

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

#1574

Description of changes:

Run eksctl anywhere create cluster -f snow-workload-1.yaml --kubeconfig mgmt.kubeconfig and create a eks-a workload cluster on snow.

  • Add snow api v1beta1 to kube runtime scheme
  • Update MachineDeployment and KubeConfigTemplate name so that clusters under the same management cluster set have unique names

Testing (if applicable):

  • Unit tests
  • Created a workload cluster on snow

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jiayiwang7 jiayiwang7 requested a review from mdsgabriel May 23, 2022 22:16
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2225 (57c4c15) into main (549d336) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2225      +/-   ##
==========================================
+ Coverage   51.71%   51.72%   +0.01%     
==========================================
  Files         313      313              
  Lines       26050    26056       +6     
==========================================
+ Hits        13471    13477       +6     
  Misses      11281    11281              
  Partials     1298     1298              
Impacted Files Coverage Δ
pkg/clients/kubernetes/scheme.go 50.00% <ø> (ø)
pkg/clusterapi/apibuilder.go 90.43% <100.00%> (ø)
pkg/clusterapi/name.go 87.50% <100.00%> (+4.16%) ⬆️
pkg/providers/snow/fetch.go 100.00% <100.00%> (ø)
pkg/providers/snow/objects.go 79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549d336...57c4c15. Read the comment docs.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 925001e into aws:main May 24, 2022
@jiayiwang7 jiayiwang7 deleted the snow-workload branch May 24, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants