Add proxy config setup when generating CAPI objects in apibuilder #2262
Conversation
eks-distro-bot
added
the
size/L
# Conflicts: # cmd/integration_test/build/buildspecs/test-eks-a-cli.yml
Codecov Report
@@ Coverage Diff @@
## main #2262 +/- ##
==========================================
+ Coverage 51.80% 51.86% +0.06%
==========================================
Files 313 315 +2
Lines 25967 26054 +87
==========================================
+ Hits 13451 13514 +63
- Misses 11226 11242 +16
- Partials 1290 1298 +8
Continue to review full report at Codecov.
|
jiayiwang7
changed the title
pkg/clusterapi/kubeadm_commands.go
Outdated
|
|
||
| var restartContainerdCommands = []string{ | ||
| "sudo systemctl daemon-reload", | ||
| "sudo systemctl restart containerd", |
There was a problem hiding this comment.
These commands only apply to OS with systemctl (unless I'm missing something)
Should we build this in a different way so it's opt-in from the provider? Or maybe even run it from the provider
| } | ||
|
|
||
| return bootstrapv1.File{ | ||
| Path: "/etc/systemd/system/containerd.service.d/http-proxy.conf", |
There was a problem hiding this comment.
Similar comment here about different OS
I believe this works differently for Bottlerocket (for example)
There was a problem hiding this comment.
proxy config setup in provider now
# Conflicts: # cmd/integration_test/build/buildspecs/test-eks-a-cli.yml
eks-distro-bot
added
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
#1574
Description of changes:
Add proxy config setup when generating CAPI objects in apibuilder
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.