-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait adaptive duration per unready replicas between retries #2381
Wait adaptive duration per unready replicas between retries #2381
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
- Coverage 56.09% 54.16% -1.94%
==========================================
Files 303 304 +1
Lines 24657 26164 +1507
==========================================
+ Hits 13831 14171 +340
- Misses 9533 10677 +1144
- Partials 1293 1316 +23
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
If we can increase the test coverage for the diff a bit, it's ready to go
/lgtm |
1163016
to
b2caf95
Compare
b2caf95
to
013035c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
Currently it waits zero seconds between retries when waiting for all machine deployment replicas are ready. This PR introduces a wait time adaptive to unready replicas between retries.
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.