Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait adaptive duration per unready replicas between retries #2381

Conversation

wongni
Copy link
Contributor

@wongni wongni commented Jun 9, 2022

Issue #, if available:

Description of changes:
Currently it waits zero seconds between retries when waiting for all machine deployment replicas are ready. This PR introduces a wait time adaptive to unready replicas between retries.

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2022
@wongni
Copy link
Contributor Author

wongni commented Jun 9, 2022

/cc @chrisdoherty4 @g-gaston

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #2381 (1163016) into main (1484135) will decrease coverage by 1.93%.
The diff coverage is 96.77%.

❗ Current head 1163016 differs from pull request most recent head 013035c. Consider uploading reports for the commit 013035c to get more accurate results

@@            Coverage Diff             @@
##             main    #2381      +/-   ##
==========================================
- Coverage   56.09%   54.16%   -1.94%     
==========================================
  Files         303      304       +1     
  Lines       24657    26164    +1507     
==========================================
+ Hits        13831    14171     +340     
- Misses       9533    10677    +1144     
- Partials     1293     1316      +23     
Impacted Files Coverage Δ
pkg/clustermanager/cluster_manager.go 54.49% <93.33%> (+1.32%) ⬆️
pkg/executables/kubectl.go 40.75% <100.00%> (+2.33%) ⬆️
pkg/api/v1alpha1/zz_generated.deepcopy.go 19.98% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1484135...013035c. Read the comment docs.

Copy link
Member

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
If we can increase the test coverage for the diff a bit, it's ready to go

pkg/clustermanager/cluster_manager.go Outdated Show resolved Hide resolved
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2022
@wongni wongni requested a review from g-gaston June 9, 2022 23:55
@g-gaston
Copy link
Member

g-gaston commented Jun 13, 2022

/lgtm
we just need to get the test coverage a bit higher

@eks-distro-bot eks-distro-bot added lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 13, 2022
@wongni wongni force-pushed the wait-adaptive-duration-per-unready-replicas-between-retries branch from 1163016 to b2caf95 Compare June 13, 2022 18:24
@wongni wongni force-pushed the wait-adaptive-duration-per-unready-replicas-between-retries branch from b2caf95 to 013035c Compare June 13, 2022 19:49
@g-gaston
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit c96cc72 into aws:main Jun 13, 2022
@wongni wongni deleted the wait-adaptive-duration-per-unready-replicas-between-retries branch June 13, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants