Add normalizations and lower case MAC address #2389
Conversation
eks-distro-bot
added
the
size/L
chrisdoherty4
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
- Coverage 56.03% 53.84% -2.19%
==========================================
Files 302 304 +2
Lines 24615 25963 +1348
==========================================
+ Hits 13792 13981 +189
- Misses 9531 10674 +1143
- Partials 1292 1308 +16
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
When reading hardware data for Tinkerbell we need to apply normalizations so we can perform comparison operations. MAC Addresses are a culprit for incorrect comparisons because comparators don't take into consideration case insensitivty of a MAC. We're lower-casing MAC as it seems to be lower-case more often than not.
When reading hardware data for Tinkerbell we need to apply normalizations so we can perform comparison operations. MAC Addresses are a culprit for incorrect comparisons because comparators don't take into consideration case insensitivty of a MAC.
We're lower-casing MAC as it seems to be lower-case more often than not.
This won't protect us against all failures. A real fix would be to edit all locations within Tinkerbell that perform a MAC comparison to be case-insensitive.