Enable hostPort for tink services only on bootstrap #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
+ Coverage 56.07% 56.09% +0.02%
==========================================
Files 303 303
Lines 24645 24657 +12
==========================================
+ Hits 13819 13831 +12
Misses 9533 9533
Partials 1293 1293
Continue to review full report at Codecov.
|
jacobweinstock
approved these changes
Jun 13, 2022
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
hostPortis needed forhegelandtink-serveron local Kind cluster but it's not needed when the Tinkerbell stack on the workload cluster. This PR enableshostPortfor tink services only for bootstrap phase.These are the helm chart values that are used to control hostPort for deployments https://github.com/aws/eks-anywhere-build-tooling/blob/main/projects/tinkerbell/tinkerbell-chart/chart/values.yaml#L32-L34
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.