Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels support in apibuilder #2408

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

#1574

Description of changes:

Add labels support to KubeadmControlPlane and KubeadmConfigTemplate.

Testing (if applicable):

Unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jiayiwang7 jiayiwang7 requested a review from g-gaston June 14, 2022 21:55
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #2408 (0005c4b) into main (19348d0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2408   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files         305      305           
  Lines       24773    24775    +2     
=======================================
+ Hits        14002    14004    +2     
  Misses       9475     9475           
  Partials     1296     1296           
Impacted Files Coverage Δ
pkg/clusterapi/apibuilder.go 93.26% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19348d0...0005c4b. Read the comment docs.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 5063b92 into aws:main Jun 14, 2022
@jiayiwang7 jiayiwang7 deleted the labels branch June 28, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants