Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.10] Adds wait for not ready for external etcd before upgrade #2676

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #2640

/assign mitalipaygude

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 7, 2022
@mitalipaygude mitalipaygude reopened this Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-0.10@72a2ab6). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.10    #2676   +/-   ##
===============================================
  Coverage                ?   57.53%           
===============================================
  Files                   ?      308           
  Lines                   ?    25487           
  Branches                ?        0           
===============================================
  Hits                    ?    14663           
  Misses                  ?     9497           
  Partials                ?     1327           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a2ab6...a28d9b0. Read the comment docs.

@pokearu
Copy link
Member

pokearu commented Jul 7, 2022

/ok-to-test

@mitalipaygude
Copy link
Member

/override eks-anywhere-attribution-files-presubmit
/override eks-anywhere-presubmit

@eks-distro-bot
Copy link
Collaborator

@mitalipaygude: Overrode contexts on behalf of mitalipaygude: eks-anywhere-attribution-files-presubmit, eks-anywhere-presubmit

In response to this:

/override eks-anywhere-attribution-files-presubmit
/override eks-anywhere-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mitalipaygude
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitalipaygude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 0915b7b into aws:release-0.10 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants