Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dev release S3 bucket references with Cloudfront domain #2780

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

abhay-krishna
Copy link
Member

Replace dev release S3 bucket references with Cloudfront domain dev-release-assets.eks-anywhere.model-rocket.aws.dev.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #2780 (fe8375b) into main (7475d27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2780   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files         318      318           
  Lines       26070    26070           
=======================================
  Hits        15558    15558           
  Misses       9200     9200           
  Partials     1312     1312           
Impacted Files Coverage Δ
pkg/manifests/releases/read.go 81.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7475d27...fe8375b. Read the comment docs.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/cherrypick release-0.10

@eks-distro-pr-bot
Copy link
Contributor

@abhay-krishna: new pull request created: #2782

In response to this:

/cherrypick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna abhay-krishna deleted the replace-s3-cloudfront branch September 21, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants