Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Validate VSphere User Privs" #3136

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

jonathanmeier5
Copy link
Member

Reverts #2907

Reverting because VMC gives users a different set of permissions than those outlined in docs. While this is merged, deploying to VMC is borked. I'm hoping to just take the VMC privs and validate on those.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jonathanmeier5 jonathanmeier5 marked this pull request as ready for review August 23, 2022 22:29
@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress labels Aug 23, 2022
@jonathanmeier5
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathanmeier5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #3136 (54ad7a3) into main (e6da229) will decrease coverage by 0.31%.
The diff coverage is 92.10%.

@@            Coverage Diff             @@
##             main    #3136      +/-   ##
==========================================
- Coverage   62.81%   62.49%   -0.32%     
==========================================
  Files         340      334       -6     
  Lines       27280    26919     -361     
==========================================
- Hits        17136    16824     -312     
+ Misses       8837     8810      -27     
+ Partials     1307     1285      -22     
Impacted Files Coverage Δ
pkg/executables/executables.go 7.14% <ø> (ø)
pkg/providers/vsphere/envars.go 43.75% <66.66%> (ø)
pkg/providers/vsphere/vsphere.go 64.97% <96.15%> (-0.95%) ⬇️
pkg/dependencies/factory.go 67.76% <100.00%> (-0.28%) ⬇️
pkg/executables/govc.go 59.71% <100.00%> (ø)
pkg/providers/vsphere/validator.go 61.67% <100.00%> (-11.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonathanmeier5
Copy link
Member Author

/test eks-anywhere-presubmit

@eks-distro-bot eks-distro-bot merged commit 3ca04dd into main Aug 24, 2022
jonathanmeier5 added a commit to jonathanmeier5/eks-anywhere that referenced this pull request Aug 24, 2022
eks-distro-bot pushed a commit that referenced this pull request Aug 25, 2022
* Revert "Revert "Add vSphere priv check (#2907)" (#3136)"

This reverts commit 3ca04dd.

* Validate vmc privs with warning
eks-distro-pr-bot pushed a commit to eks-distro-pr-bot/eks-anywhere that referenced this pull request Aug 26, 2022
eks-distro-bot pushed a commit that referenced this pull request Aug 26, 2022
* Revert "Revert "Add vSphere priv check (#2907)" (#3136)"

This reverts commit 3ca04dd.

* Validate vmc privs with warning

Co-authored-by: Jonathan Meier <jwmeier@amazon.com>
@TerryHowe TerryHowe deleted the revert-2907-vsphere-priv-check branch October 27, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants