Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iam auth role upgrades #3399

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Sep 20, 2022

Issue #3390

Description of changes:
Changes enable detection of diff in the cluster config for AWSIamConfig MapRoles and MapUsers during upgrade.

Testing:

./eksctl-anywhere upgrade cluster -f ./eks-a-cluster.yaml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #3399 (85eb3bf) into main (9d56db8) will decrease coverage by 0.02%.
The diff coverage is 46.34%.

@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
- Coverage   64.87%   64.85%   -0.03%     
==========================================
  Files         352      352              
  Lines       28357    28394      +37     
==========================================
+ Hits        18397    18415      +18     
- Misses       8648     8666      +18     
- Partials     1312     1313       +1     
Impacted Files Coverage Δ
controllers/resource/fetcher.go 40.26% <0.00%> (-0.56%) ⬇️
pkg/cluster/spec.go 63.47% <0.00%> (-0.92%) ⬇️
pkg/cluster/fetch.go 45.58% <44.44%> (+0.58%) ⬆️
pkg/clustermanager/cluster_manager.go 62.90% <100.00%> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pokearu pokearu merged commit f88b7af into aws:main Sep 20, 2022
@pokearu
Copy link
Member Author

pokearu commented Sep 27, 2022

/cherrypick release-0.11

@eks-distro-pr-bot
Copy link
Contributor

@pokearu: new pull request created: #3460

In response to this:

/cherrypick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants