Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.12] Plumbing validation error back to user #3832

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #3827

/assign maxdrib

@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-0.12@3e2a441). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.12    #3832   +/-   ##
===============================================
  Coverage                ?   67.08%           
===============================================
  Files                   ?      369           
  Lines                   ?    30637           
  Branches                ?        0           
===============================================
  Hits                    ?    20552           
  Misses                  ?     8705           
  Partials                ?     1380           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 29cc47e into aws:release-0.12 Oct 26, 2022
ahreehong pushed a commit to ahreehong/eks-anywhere that referenced this pull request Nov 8, 2022
Co-authored-by: Max Dribinsky <dribinm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants