Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker count pointer dereference fix #3852

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Oct 30, 2022

Description of changes:
The workerNodeGroupConfiguration.Count was made an Integer pointer #3624. Adding a fix for places where the pointer was not dereferenced when the value needed to be compared.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2022
@pokearu pokearu requested a review from abhay-krishna October 30, 2022 03:05
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #3852 (1215cf0) into main (fffb8c5) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3852      +/-   ##
==========================================
+ Coverage   67.40%   67.48%   +0.08%     
==========================================
  Files         376      376              
  Lines       30938    30938              
==========================================
+ Hits        20853    20880      +27     
+ Misses       8705     8673      -32     
- Partials     1380     1385       +5     
Impacted Files Coverage Δ
pkg/providers/nutanix/template.go 88.80% <100.00%> (ø)
pkg/providers/tinkerbell/assert.go 55.73% <100.00%> (+6.96%) ⬆️
pkg/providers/tinkerbell/upgrade.go 10.08% <100.00%> (+4.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 91f1ae1 into aws:main Oct 30, 2022
@pokearu
Copy link
Member Author

pokearu commented Oct 30, 2022

/cherrypick release-0.12

@eks-distro-pr-bot
Copy link
Contributor

@pokearu: #3852 failed to apply on top of branch "release-0.12":

Applying: Fixing worker node group count dereference error for tinkerbell
Using index info to reconstruct a base tree...
M	pkg/providers/tinkerbell/tinkerbell_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/providers/tinkerbell/tinkerbell_test.go
CONFLICT (content): Merge conflict in pkg/providers/tinkerbell/tinkerbell_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fixing worker node group count dereference error for tinkerbell
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pokearu added a commit to pokearu/eks-anywhere that referenced this pull request Oct 31, 2022
* Fixing worker node group count dereference error for tinkerbell

* Fixing worker node group count dereference for nutanix

(cherry picked from commit 91f1ae1)
pokearu added a commit to pokearu/eks-anywhere that referenced this pull request Oct 31, 2022
* Fixing worker node group count dereference error for tinkerbell

* Fixing worker node group count dereference for nutanix

(cherry picked from commit 91f1ae1)
eks-distro-bot pushed a commit that referenced this pull request Oct 31, 2022
* Fixing worker node group count dereference error for tinkerbell

* Fixing worker node group count dereference for nutanix

(cherry picked from commit 91f1ae1)
ahreehong pushed a commit to ahreehong/eks-anywhere that referenced this pull request Nov 8, 2022
* Fixing worker node group count dereference error for tinkerbell

* Fixing worker node group count dereference for nutanix

(cherry picked from commit 91f1ae1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants