-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worker count pointer dereference fix #3852
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3852 +/- ##
==========================================
+ Coverage 67.40% 67.48% +0.08%
==========================================
Files 376 376
Lines 30938 30938
==========================================
+ Hits 20853 20880 +27
+ Misses 8705 8673 -32
- Partials 1380 1385 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.12 |
@pokearu: #3852 failed to apply on top of branch "release-0.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Fixing worker node group count dereference error for tinkerbell * Fixing worker node group count dereference for nutanix (cherry picked from commit 91f1ae1)
* Fixing worker node group count dereference error for tinkerbell * Fixing worker node group count dereference for nutanix (cherry picked from commit 91f1ae1)
Description of changes:
The
workerNodeGroupConfiguration.Count
was made an Integer pointer #3624. Adding a fix for places where the pointer was not dereferenced when the value needed to be compared.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.