Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document cluster topologies #4070

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Conversation

chrisnegus
Copy link
Member

Description of changes: This PR documents the different cluster topologies (standalone vs. management/workload) that are supported by EKS Anywhere.

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #4070 (6d29724) into main (a93e07f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4070      +/-   ##
==========================================
- Coverage   67.56%   67.55%   -0.02%     
==========================================
  Files         394      396       +2     
  Lines       32001    32005       +4     
==========================================
- Hits        21623    21622       -1     
- Misses       8957     8960       +3     
- Partials     1421     1423       +2     
Impacted Files Coverage Δ
pkg/features/features.go 25.00% <0.00%> (-9.15%) ⬇️
internal/pkg/api/nutanix.go 81.03% <0.00%> (-2.01%) ⬇️
pkg/validations/cluster.go 91.17% <0.00%> (-1.33%) ⬇️
pkg/curatedpackages/packagecontrollerclient.go 96.36% <0.00%> (-0.23%) ⬇️
pkg/controller/clusters/registry.go 100.00% <0.00%> (ø)
...idations/createvalidations/preflightvalidations.go 100.00% <0.00%> (ø)
...dations/upgradevalidations/preflightvalidations.go 100.00% <0.00%> (ø)
pkg/kubeconfig/fmt.go 0.00% <0.00%> (ø)
pkg/providers/docker/reconciler/reconciler.go 100.00% <0.00%> (ø)
pkg/networking/cilium/reconciler/reconciler.go 86.95% <0.00%> (+0.11%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe
Copy link
Contributor

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TerryHowe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 847d382 into aws:main Nov 16, 2022
@chrisnegus
Copy link
Member Author

/cherrypick release-0.12

@eks-distro-pr-bot
Copy link
Contributor

@chrisnegus: new pull request created: #4116

In response to this:

/cherrypick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants