Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd kubelet extra arg #4266

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

mitalipaygude
Copy link
Member

Description of changes:

  • TestDockerKubernetes123to124UpgradeFromLatestMinorRelease has been failing for the last few runs. This PR fixes that for unstacked topology.

Testing (if applicable):

  • make e2e
  • Run manual upgrade test
  • Run e2e test TestDockerKubernetes123to124UpgradeFromLatestMinorRelease

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #4266 (637aec7) into main (af479f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4266   +/-   ##
=======================================
  Coverage   68.46%   68.46%           
=======================================
  Files         404      404           
  Lines       32793    32797    +4     
=======================================
+ Hits        22451    22455    +4     
  Misses       8901     8901           
  Partials     1441     1441           
Impacted Files Coverage Δ
pkg/clusterapi/extraargs.go 97.14% <100.00%> (+0.11%) ⬆️
pkg/providers/docker/docker.go 71.63% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mitalipaygude
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitalipaygude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 2fde321 into aws:main Dec 2, 2022
d8660091 pushed a commit to d8660091/eks-anywhere that referenced this pull request Dec 2, 2022
* Merge

* Add systemd kubelet extra arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants