Refactor ip in use algorithm

[chrisdoherty4]

Refactor the IsIPInUse algorithm to be faster and more reliable.

The IsIPInUse algorithm iterated over a series of ports testing if they were open at some target address via TCP. It failed to take into consideration devices that are serving the IP but have no services listening on the checked ports resulting in a false negative.

Instead of relying on ports we can focus on whether the device responded. That can be achieved by either validating a TCP connection was in-fact established, or simply that the connection was reset by the server. The timeout period is still our indicator that the IP is not in use.

This check is still best effort but fixes the false negative case where none of the checked ports are open while also being 2s faster making it more appropriate for use in webhooks if desired.

Additional testing

I manually verified the errors returned by running the algorithm as part of an independent binary.

[eks-distro-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Merging #4268 (4c47a60) into main (e041387) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4c47a60 differs from pull request most recent head 239c678. Consider uploading reports for the commit 239c678 to get more accurate results

@@            Coverage Diff             @@
##             main    #4268      +/-   ##
==========================================
- Coverage   68.51%   68.50%   -0.02%     
==========================================
  Files         404      404              
  Lines       32940    32939       -1     
==========================================
- Hits        22568    22564       -4     
- Misses       8924     8926       +2     
- Partials     1448     1449       +1     

Impacted Files	Coverage Δ
pkg/providers/tinkerbell/tinkerbell.go	51.35% <ø> (ø)
pkg/networkutils/networkutils.go	67.56% <100.00%> (-0.86%)	⬇️
pkg/providers/vsphere/vsphere.go	62.90% <0.00%> (-0.43%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[chrisdoherty4]

/approve

[eks-distro-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrisdoherty4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[g-gaston]

/lgtm