Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Disable CSI e2e test #4271

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Update Disable CSI e2e test #4271

merged 1 commit into from
Dec 8, 2022

Conversation

taneyland
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022 •
edited
Loading

Codecov Report

Merging #4271 (24ceca4) into main (6279d8a) will increase coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #4271      +/-   ##
==========================================
+ Coverage   68.46%   68.64%   +0.17%     
==========================================
  Files         404      406       +2     
  Lines       32797    33120     +323     
==========================================
+ Hits        22455    22735     +280     
- Misses       8901     8933      +32     
- Partials     1441     1452      +11
Impacted Files Coverage Δ
pkg/executables/kubectl.go 54.35% <0.00%> (+0.40%) ⬆️
pkg/features/features.go 12.90% <0.00%> (-12.10%) ⬇️
pkg/controller/clusters/validations.go 88.00% <0.00%> (-12.00%) ⬇️
pkg/providers/nutanix/validator.go 88.17% <0.00%> (-11.83%) ⬇️
pkg/curatedpackages/packagecontrollerclient.go 92.73% <0.00%> (-3.63%) ⬇️
pkg/api/v1alpha1/nutanixmachineconfig.go 96.72% <0.00%> (-3.28%) ⬇️
pkg/providers/tinkerbell/tinkerbell.go 49.29% <0.00%> (-2.06%) ⬇️
pkg/providers/snow/reconciler/reconciler.go 87.67% <0.00%> (-1.36%) ⬇️
pkg/providers/nutanix/env.go 80.00% <0.00%> (-1.25%) ⬇️
pkg/providers/vsphere/reconciler/reconciler.go 80.41% <0.00%> (-1.16%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@taneyland taneyland force-pushed the update_e2e_disable_csi branch 2 times, most recently from 19c7ea7 to a86cc51 Compare December 2, 2022 19:52
@taneyland taneyland force-pushed the update_e2e_disable_csi branch from a86cc51 to 153de76 Compare December 2, 2022 21:50
@taneyland taneyland requested a review from g-gaston December 2, 2022 21:50
@taneyland taneyland force-pushed the update_e2e_disable_csi branch from 153de76 to b6c4701 Compare December 7, 2022 18:02
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@taneyland taneyland force-pushed the update_e2e_disable_csi branch 2 times, most recently from c7b3f18 to 8328af9 Compare December 8, 2022 14:49
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 8, 2022
@taneyland taneyland force-pushed the update_e2e_disable_csi branch from 8328af9 to 5c2b58e Compare December 8, 2022 16:45
@taneyland taneyland force-pushed the update_e2e_disable_csi branch from 5c2b58e to 24ceca4 Compare December 8, 2022 17:28
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2022
taneyland
taneyland commented Dec 8, 2022
View reviewed changes
pkg/executables/kubectl_test.go
@@ -2001,7 +2001,7 @@ func TestKubectlGetClusterResourceSet(t *testing.T) {

tt.e.EXPECT().Execute(
tt.ctx,
"get", "clusterresourcesets.addons.cluster.x-k8s.io", resourceSetName, "-o", "json", "--kubeconfig", tt.cluster.KubeconfigFile, "--namespace", tt.namespace,
"get", "--ignore-not-found", "-o", "json", "--kubeconfig", tt.cluster.KubeconfigFile, "clusterresourcesets.addons.cluster.x-k8s.io", "--namespace", tt.namespace, resourceSetName,
).Return(*bytes.NewBufferString(resourceSetJson), nil)

gotResourceSet, err := tt.k.GetClusterResourceSet(tt.ctx, tt.cluster.KubeconfigFile, resourceSetName, tt.namespace)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why codecov isn't picking up that this is tested

@taneyland
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taneyland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@taneyland taneyland merged commit 56cad59 into aws:main Dec 8, 2022
@taneyland
Copy link
Member Author

/cherry-pick release-0.13

@eks-distro-pr-bot
Copy link
Contributor

@taneyland: new pull request could not be created: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between aws:release-0.13 and eks-distro-pr-bot:cherry-pick-4271-to-release-0.13"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherry-pick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston g-gaston approved these changes

Assignees

@g-gaston g-gaston

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taneyland @eks-distro-bot @eks-distro-pr-bot @g-gaston