-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added template modifications for uuid in machineconfig #4283
added template modifications for uuid in machineconfig #4283
Conversation
Hi @deepakm-ntnx. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7f0b260
to
f5e9e44
Compare
Codecov Report
@@ Coverage Diff @@
## main #4283 +/- ##
==========================================
+ Coverage 68.52% 68.61% +0.08%
==========================================
Files 404 406 +2
Lines 32935 33086 +151
==========================================
+ Hits 22568 22701 +133
- Misses 8919 8933 +14
- Partials 1448 1452 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/ok-to-test |
default to name till ci is fixed to pass uuid in test
f5e9e44
to
f23b655
Compare
/test eks-anywhere-presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test eks-anywhere-presubmit |
Issue #, if available:
Description of changes:
Now passing uuid instead of name if provided by user to capx provider.
Also added simpleflow tests with uuid for e2e tests for all k8s versions
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.