Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports to use aws etcdadm provider repos #4295

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

g-gaston
Copy link
Member

@g-gaston g-gaston commented Dec 6, 2022

Description of changes

Just updating imports, no other changes. We created the repos in the aws org but never updated our imports.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2022
@g-gaston
Copy link
Member Author

g-gaston commented Dec 6, 2022

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g-gaston g-gaston force-pushed the update-etcdadm-imports branch from 7e36c6a to 192b78a Compare December 6, 2022 18:24
@eks-distro-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@g-gaston
Copy link
Member Author

g-gaston commented Dec 6, 2022

Had to regenerate the mocks due to import order diff

@g-gaston g-gaston added the lgtm label Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #4295 (192b78a) into main (3875a4a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4295      +/-   ##
==========================================
+ Coverage   68.48%   68.52%   +0.03%     
==========================================
  Files         404      404              
  Lines       32830    32948     +118     
==========================================
+ Hits        22484    22576      +92     
- Misses       8903     8924      +21     
- Partials     1443     1448       +5     
Impacted Files Coverage Δ
controllers/resource/fetcher.go 40.26% <ø> (ø)
controllers/resource/template.go 37.78% <ø> (ø)
pkg/clusterapi/controlplane.go 100.00% <ø> (ø)
pkg/clusterapi/yaml/controlplane.go 89.15% <ø> (ø)
pkg/clustermanager/cluster_manager.go 70.69% <ø> (+1.28%) ⬆️
pkg/controller/clusters/controlplane.go 83.01% <ø> (ø)
pkg/executables/kubectl.go 54.09% <ø> (+0.12%) ⬆️
pkg/providers/cloudstack/cloudstack.go 71.23% <ø> (ø)
pkg/providers/docker/docker.go 71.63% <ø> (ø)
pkg/providers/tinkerbell/template.go 43.20% <ø> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eks-distro-bot eks-distro-bot merged commit 796e609 into aws:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants