Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADOT e2e for vSphere #4312

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Add ADOT e2e for vSphere #4312

merged 3 commits into from
Dec 7, 2022

Conversation

ivyostosh
Copy link
Member

Issue #, if available: aws/eks-anywhere-packages#631

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #4312 (23b1d95) into main (e041387) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4312      +/-   ##
==========================================
+ Coverage   68.51%   68.61%   +0.10%     
==========================================
  Files         404      406       +2     
  Lines       32940    33092     +152     
==========================================
+ Hits        22568    22707     +139     
- Misses       8924     8933       +9     
- Partials     1448     1452       +4     
Impacted Files Coverage Δ
pkg/executables/kubectl.go 54.30% <100.00%> (+0.21%) ⬆️
pkg/curatedpackages/packagecontrollerclient.go 92.73% <0.00%> (-3.63%) ⬇️
pkg/api/v1alpha1/nutanixmachineconfig.go 96.72% <0.00%> (-3.28%) ⬇️
pkg/providers/tinkerbell/tinkerbell.go 49.29% <0.00%> (-2.06%) ⬇️
pkg/networkutils/networkutils.go 67.56% <0.00%> (-0.86%) ⬇️
pkg/providers/tinkerbell/stack/stack.go 83.41% <0.00%> (-0.31%) ⬇️
pkg/dependencies/factory.go 72.12% <0.00%> (-0.22%) ⬇️
pkg/providers/vsphere/vsphere.go 63.27% <0.00%> (-0.06%) ⬇️
pkg/executables/helm.go 74.33% <0.00%> (ø)
pkg/networking/cilium/templater.go 96.15% <0.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonahjon
Copy link
Contributor

jonahjon commented Dec 7, 2022

/lgtm

@junshun
Copy link
Member

junshun commented Dec 7, 2022

/lgtm

@ivyostosh
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivyostosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 95553fd into aws:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants