Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding autoscaling annotations to nutanix #4314

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

junshun
Copy link
Member

@junshun junshun commented Dec 7, 2022

Adding autoscaling annotations to nutanix to support cluster-autoscaler package

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@junshun junshun self-assigned this Dec 7, 2022
@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #4314 (7fc96fc) into main (2412bef) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4314      +/-   ##
==========================================
+ Coverage   68.61%   68.62%   +0.01%     
==========================================
  Files         406      406              
  Lines       33086    33104      +18     
==========================================
+ Hits        22701    22719      +18     
  Misses       8933     8933              
  Partials     1452     1452              
Impacted Files Coverage Δ
pkg/providers/tinkerbell/tinkerbell.go 49.29% <ø> (ø)
pkg/networkutils/networkutils.go 67.56% <100.00%> (-0.86%) ⬇️
pkg/providers/nutanix/template.go 89.79% <100.00%> (+0.06%) ⬆️
pkg/providers/snow/snow.go 67.58% <0.00%> (+3.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2022
@jonathanmeier5
Copy link
Member

/lgtm

I defer to @abhinavmpandey08 on nutanix-specific stuff.

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit a1c21f7 into aws:main Dec 7, 2022
@deepakm-ntnx
Copy link
Contributor

do we need any change in machineDeployment on capx side template https://opendocs.nutanix.com/capx/v1.1.x/experimental/autoscaler/

@deepakm-ntnx
Copy link
Contributor

do we need any change in machineDeployment on capx side template https://opendocs.nutanix.com/capx/v1.1.x/experimental/autoscaler/

nvm, its applied. thanks for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants