Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change registry.relativeurls default value to true #4315

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

vincentni
Copy link
Member

No description provided.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2022
@eks-distro-bot eks-distro-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2022
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #4315 (e654de0) into main (2412bef) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e654de0 differs from pull request most recent head ad9b9b3. Consider uploading reports for the commit ad9b9b3 to get more accurate results

@@            Coverage Diff             @@
##             main    #4315      +/-   ##
==========================================
+ Coverage   68.61%   68.63%   +0.02%     
==========================================
  Files         406      406              
  Lines       33086    33110      +24     
==========================================
+ Hits        22701    22725      +24     
  Misses       8933     8933              
  Partials     1452     1452              
Impacted Files Coverage Δ
pkg/providers/tinkerbell/tinkerbell.go 49.29% <ø> (ø)
pkg/networkutils/networkutils.go 67.56% <100.00%> (-0.86%) ⬇️
pkg/executables/kubectl.go 54.30% <0.00%> (+0.21%) ⬆️
pkg/providers/snow/snow.go 67.58% <0.00%> (+3.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vincentni vincentni requested a review from TerryHowe December 7, 2022 20:04
@jonahjon
Copy link
Contributor

jonahjon commented Dec 7, 2022

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonahjon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 72543aa into aws:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved documentation lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants