Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / update ADOT e2e test cases #4334

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

ivyostosh
Copy link
Member

Added test cases for Cloudstack, Nutanix, and Tinkerbell; updated test cases for Docker and vSphere

Issue #, if available: aws/eks-anywhere-packages#631

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added test cases for Cloudstack, Nutanix, and Tinkerbell; updated test cases for Docker and vSphere
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 8, 2022
}

func TestCPackagesAdotTinkerbellBottleRocketKubernetes123SingleNodeFlow(t *testing.T) {
test := framework.NewClusterE2ETest(t,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have credential check here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test := framework.NewClusterE2ETest(t,
framework.CheckCuratedPackagesCredentials(t)
test := framework.NewClusterE2ETest(t,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

}

func TestCPackagesAdotTinkerbellUbuntuKubernetes122SingleNodeFlow(t *testing.T) {
test := framework.NewClusterE2ETest(t,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credential check here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
test := framework.NewClusterE2ETest(t,
framework.CheckCuratedPackagesCredentials(t)
test := framework.NewClusterE2ETest(t,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

kubeconfig.FromClusterName(test.ClusterName), adotTargetNamespace,
"--set mode=deployment")
test.VerifyAdotPackageInstalled(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace)
test.VerifyAdotPackageDeploymentUpdated(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace)
test.VerifyAdotPackageDaemonSetUpdated(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace)
})
}

func runCuratedPackagesAdotInstallTinkerbellSingleNodeFlow(test *framework.ClusterE2ETest) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this type of function go in cluster.go? It seems to be mostly generic function calls more slated torwards tinkerbell with the only specific adot related to call a function test. Maybe having a tinkerbell setup and tinkerbell teardown is better. Especially if we want to test other flows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #4336

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #4334 (ed1824f) into main (95553fd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4334   +/-   ##
=======================================
  Coverage   68.63%   68.64%           
=======================================
  Files         406      406           
  Lines       33110    33125   +15     
=======================================
+ Hits        22725    22737   +12     
- Misses       8933     8935    +2     
- Partials     1452     1453    +1     
Impacted Files Coverage Δ
pkg/providers/nutanix/env.go 80.00% <0.00%> (-1.25%) ⬇️
pkg/providers/nutanix/provider.go 74.21% <0.00%> (ø)
pkg/providers/nutanix/template.go 89.79% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@junshun
Copy link
Member

junshun commented Dec 8, 2022

/lgtm

@ivyostosh
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivyostosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 429e9e9 into aws:main Dec 8, 2022
@ivyostosh ivyostosh deleted the adot-new-e2e branch January 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants