-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add / update ADOT e2e test cases #4334
Conversation
Added test cases for Cloudstack, Nutanix, and Tinkerbell; updated test cases for Docker and vSphere
} | ||
|
||
func TestCPackagesAdotTinkerbellBottleRocketKubernetes123SingleNodeFlow(t *testing.T) { | ||
test := framework.NewClusterE2ETest(t, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have credential check here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test := framework.NewClusterE2ETest(t, | |
framework.CheckCuratedPackagesCredentials(t) | |
test := framework.NewClusterE2ETest(t, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
} | ||
|
||
func TestCPackagesAdotTinkerbellUbuntuKubernetes122SingleNodeFlow(t *testing.T) { | ||
test := framework.NewClusterE2ETest(t, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
credential check here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test := framework.NewClusterE2ETest(t, | |
framework.CheckCuratedPackagesCredentials(t) | |
test := framework.NewClusterE2ETest(t, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
kubeconfig.FromClusterName(test.ClusterName), adotTargetNamespace, | ||
"--set mode=deployment") | ||
test.VerifyAdotPackageInstalled(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace) | ||
test.VerifyAdotPackageDeploymentUpdated(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace) | ||
test.VerifyAdotPackageDaemonSetUpdated(adotPackagePrefix+"-"+adotPackageName, adotTargetNamespace) | ||
}) | ||
} | ||
|
||
func runCuratedPackagesAdotInstallTinkerbellSingleNodeFlow(test *framework.ClusterE2ETest) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this type of function go in cluster.go? It seems to be mostly generic function calls more slated torwards tinkerbell with the only specific adot related to call a function test. Maybe having a tinkerbell setup and tinkerbell teardown is better. Especially if we want to test other flows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see #4336
Codecov Report
@@ Coverage Diff @@
## main #4334 +/- ##
=======================================
Coverage 68.63% 68.64%
=======================================
Files 406 406
Lines 33110 33125 +15
=======================================
+ Hits 22725 22737 +12
- Misses 8933 8935 +2
- Partials 1452 1453 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivyostosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added test cases for Cloudstack, Nutanix, and Tinkerbell; updated test cases for Docker and vSphere
Issue #, if available: aws/eks-anywhere-packages#631
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.