Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate OIDC Config for Nutanix #4711

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Propagate OIDC Config for Nutanix #4711

merged 2 commits into from
Jan 25, 2023

Conversation

thunderboltsid
Copy link
Contributor

Ensure OIDC config is propogated to KubeAdmControlPlane via
API Server extra args for the Nutanix provider.

@eks-distro-bot
Copy link
Collaborator

Hi @thunderboltsid. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #4711 (ab64ebe) into main (97d9e1a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4711   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files         414      414           
  Lines       33428    33430    +2     
=======================================
+ Hits        23945    23947    +2     
  Misses       7990     7990           
  Partials     1493     1493
Impacted Files Coverage Δ
pkg/providers/nutanix/template.go 89.93% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abhinavmpandey08
Copy link
Member

/ok-to-test

@thunderboltsid
Propagate OIDC Config for Nutanix
917ee10 
Ensure OIDC config is propogated to KubeAdmControlPlane via
API Server extra args for the Nutanix provider.
@thunderboltsid
Add OIDC related tests for Nutanix provider
ab64ebe 
- Added OIDC e2e tests for Kubernetes 1.21 - 1.25
- Added unit test for OIDC config w/ Nutanix
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2023
@thunderboltsid
Copy link
Contributor Author

Uncommented the 1.25 e2e test as other 1.25 tests have now been merged too.

abhinavmpandey08
abhinavmpandey08 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit f55a4b4 into aws:main Jan 25, 2023
@thunderboltsid thunderboltsid deleted the oidc-nutanix branch January 26, 2023 23:53
jonahjon pushed a commit to jonahjon/eks-anywhere that referenced this pull request Jan 30, 2023
@thunderboltsid @jonahjon
Propagate OIDC Config for Nutanix (aws#4711)
0c7f3b8 
* Propagate OIDC Config for Nutanix

Ensure OIDC config is propogated to KubeAdmControlPlane via
API Server extra args for the Nutanix provider.

* Add OIDC related tests for Nutanix provider

- Added OIDC e2e tests for Kubernetes 1.21 - 1.25
- Added unit test for OIDC config w/ Nutanix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavmpandey08 abhinavmpandey08 abhinavmpandey08 approved these changes

Assignees

@abhinavmpandey08 abhinavmpandey08

Labels
approved lgtm ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thunderboltsid @eks-distro-bot @abhinavmpandey08