Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using latest package controller builds in dev bundle #4793

Merged
merged 8 commits into from
Feb 9, 2023

Conversation

jonahjon
Copy link
Contributor

Signed-off-by: jonahjon jonahjones094@gmail.com

Issue #, if available:

aws/eks-anywhere-packages#715

Description of changes:

This will pull the latest (v0.0.0) helm and image builds from the dev repository when creating a dev bundle.

If the repositories don't exist in a given account it will default to the regular tags created during dry-runs.

This was tested in my account with the latest dev builds, and worked with, and without the repositories present.

      helmChart:
        description: Helm chart for eks-anywhere-packages
        imageDigest: sha256:477eaa4f1618df01a0bb90de3a13f70cad4e411ddc063df10410a7ba01d1818c
        name: eks-anywhere-packages
        uri: 646717423341.dkr.ecr.us-west-2.amazonaws.com/eks-anywhere-packages:0.0.0-a5a5cc31867fdec4da73f95483e6893cf424f80f
      packageController:
        arch:
        - amd64
        - arm64
        description: Container image for eks-anywhere-packages image
        imageDigest: sha256:8329ac9ce813b187042e8be7736ad5d7a37d76e8d8b450c271cbf9f000ca87cc
        name: eks-anywhere-packages
        os: linux
        uri: 646717423341.dkr.ecr.us-west-2.amazonaws.com/eks-anywhere-packages:v0.0.0-a5a5cc31867fdec4da73f95483e6893cf424f80f
      tokenRefresher:
        arch:
        - amd64
        - arm64
        description: Container image for ecr-token-refresher image
        imageDigest: sha256:8329ac9ce813b187042e8be7736ad5d7a37d76e8d8b450c271cbf9f000ca87cc
        name: ecr-token-refresher
        os: linux
        uri: 646717423341.dkr.ecr.us-west-2.amazonaws.com/ecr-token-refresher:v0.0.0-a5a5cc31867fdec4da73f95483e6893cf424f80f
      version: v0.2.28+abcdef1

Signed-off-by: jonahjon <jonahjones094@gmail.com>
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #4793 (e463140) into main (f7464f3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4793   +/-   ##
=======================================
  Coverage   71.61%   71.62%           
=======================================
  Files         419      419           
  Lines       34210    34210           
=======================================
+ Hits        24501    24504    +3     
+ Misses       8179     8177    -2     
+ Partials     1530     1529    -1     
Impacted Files Coverage Δ
pkg/providers/vsphere/vsphere.go 63.00% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@junshun
Copy link
Member

junshun commented Feb 6, 2023

/lgtm
/approve

Signed-off-by: jonahjon <jonahjones094@gmail.com>
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2023
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@junshun
Copy link
Member

junshun commented Feb 9, 2023

/lgtm

@junshun
Copy link
Member

junshun commented Feb 9, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junshun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit ff25652 into aws:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants