Validate snow instance type has at least 2 default vCPU #4891
Conversation
eks-distro-bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #4891 +/- ##
=======================================
Coverage 71.61% 71.62%
=======================================
Files 419 419
Lines 34198 34210 +12
=======================================
+ Hits 24492 24504 +12
Misses 8177 8177
Partials 1529 1529
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| continue | ||
| } | ||
|
|
||
| if it.DefaultVCPU != nil && *it.DefaultVCPU < minimumVCPU { |
There was a problem hiding this comment.
Is it not possible to do it.DefaultVCPU < minimumVCPU instead?
There was a problem hiding this comment.
Nvm I see why, the int is a pointer.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiayiwang7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.14 |
|
@jiayiwang7: new pull request created: #4921 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Add vCPU check for snow instance type as kubelet requires at least 2 vCPU.
Description of changes:
Testing (if applicable):
Unit tests + manual e2e
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.