Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker airgapped test #4907

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Add Docker airgapped test #4907

merged 1 commit into from
Feb 22, 2023

Conversation

abhay-krishna
Copy link
Member

Adding airgapped test for Docker. This also adds support for configuring registry mirror on Docker.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna
Copy link
Member Author

/hold

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/hold labels Feb 11, 2023
@codecov
Copy link

codecov bot commented Feb 11, 2023 •
edited
Loading

Codecov Report

Merging #4907 (e38730e) into main (2f73822) will increase coverage by 0.02%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##             main    #4907      +/-   ##
==========================================
+ Coverage   71.96%   71.98%   +0.02%     
==========================================
  Files         419      419              
  Lines       34273    34304      +31     
==========================================
+ Hits        24663    24694      +31     
  Misses       8090     8090              
  Partials     1520     1520
Impacted Files Coverage Δ
controllers/cluster_controller_legacy.go 0.00% <ø> (ø)
pkg/providers/tinkerbell/tinkerbell.go 52.73% <ø> (ø)
pkg/providers/docker/docker.go 72.10% <86.95%> (+0.81%) ⬆️
controllers/cluster_controller.go 77.82% <100.00%> (+0.83%) ⬆️
pkg/providers/vsphere/vsphere.go 63.00% <0.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abhay-krishna abhay-krishna force-pushed the docker-airgapped branch 2 times, most recently from c4a7ec5 to d788b48 Compare February 15, 2023 19:04
@abhay-krishna
Copy link
Member Author

/retest "golangci-lint / lint"

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test eks-anywhere-attribution-files-presubmit
  • /test eks-anywhere-cluster-controller-tooling-presubmit
  • /test eks-anywhere-docs-presubmit
  • /test eks-anywhere-e2e-presubmit
  • /test eks-anywhere-mocks-presubmits
  • /test eks-anywhere-presubmit
  • /test eks-anywhere-release-tooling-presubmit
  • /test eks-anywhere-release-tooling-test-presubmit

Use /test all to run the following jobs that were automatically triggered:

  • eks-anywhere-attribution-files-presubmit
  • eks-anywhere-e2e-presubmit
  • eks-anywhere-mocks-presubmits
  • eks-anywhere-presubmit

In response to this:

/retest "golangci-lint / lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/retest lint

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test eks-anywhere-attribution-files-presubmit
  • /test eks-anywhere-cluster-controller-tooling-presubmit
  • /test eks-anywhere-docs-presubmit
  • /test eks-anywhere-e2e-presubmit
  • /test eks-anywhere-mocks-presubmits
  • /test eks-anywhere-presubmit
  • /test eks-anywhere-release-tooling-presubmit
  • /test eks-anywhere-release-tooling-test-presubmit

Use /test all to run the following jobs that were automatically triggered:

  • eks-anywhere-attribution-files-presubmit
  • eks-anywhere-e2e-presubmit
  • eks-anywhere-mocks-presubmits
  • eks-anywhere-presubmit

In response to this:

/retest lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/override lint

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: lint

In response to this:

/override lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/override "codecov/patch"

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/patch

Only the following failed contexts/checkruns were expected:

  • eks-anywhere-attribution-files-presubmit
  • eks-anywhere-e2e-presubmit
  • eks-anywhere-mocks-presubmits
  • eks-anywhere-presubmit
  • lint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna abhay-krishna force-pushed the docker-airgapped branch 10 times, most recently from ab9e466 to 26d82ab Compare February 17, 2023 20:08
@abhay-krishna abhay-krishna changed the title WIP: Add Docker airgapped test Add Docker airgapped test Feb 20, 2023
@abhay-krishna abhay-krishna force-pushed the docker-airgapped branch 2 times, most recently from abe776d to 167724c Compare February 21, 2023 02:53
@abhay-krishna
Copy link
Member Author

/retest

@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2023
@abhay-krishna abhay-krishna force-pushed the docker-airgapped branch 2 times, most recently from d46bae8 to ff5f9c8 Compare February 22, 2023 10:19
@abhay-krishna
Copy link
Member Author

/override lint

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: lint

In response to this:

/override lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/override "golangci-lint / lint"

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • golangci-lint / lint

Only the following failed contexts/checkruns were expected:

  • eks-anywhere-attribution-files-presubmit
  • eks-anywhere-e2e-presubmit
  • eks-anywhere-mocks-presubmits
  • eks-anywhere-presubmit
  • lint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "golangci-lint / lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

d8660091
d8660091 reviewed Feb 22, 2023
View reviewed changes
test/framework/cluster.go Outdated Show resolved Hide resolved
@d8660091
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member Author

/approved

@abhay-krishna
Copy link
Member Author

/approve
/unhold

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/override lint

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: lint

In response to this:

/override lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna abhay-krishna merged commit 8d1dc2c into aws:main Feb 22, 2023
raymond-zhang00 pushed a commit to raymond-zhang00/eks-anywhere that referenced this pull request Feb 27, 2023
@abhay-krishna @raymond-zhang00
Add Docker airgapped test (aws#4907)
1708085
@abhay-krishna abhay-krishna deleted the docker-airgapped branch September 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d8660091 d8660091 d8660091 left review comments

Assignees

@d8660091 d8660091

Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhay-krishna @eks-distro-bot @d8660091