Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace snow instance type exact match with regex validation (#4895) #4923

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

Manually cherry-pick #4895 as auto cherry-pick fails.

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2023
@d8660091
Copy link
Member

/lgtm

@jiayiwang7
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-0.14@7c5b3ec). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-0.14    #4923   +/-   ##
===============================================
  Coverage                ?   71.53%           
===============================================
  Files                   ?      415           
  Lines                   ?    33450           
  Branches                ?        0           
===============================================
  Hits                    ?    23928           
  Misses                  ?     8029           
  Partials                ?     1493           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eks-distro-bot eks-distro-bot merged commit 8f0c356 into aws:release-0.14 Feb 13, 2023
@jiayiwang7 jiayiwang7 deleted the snow-release branch February 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants