Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client processor for CloudStack datacenter config #5032

Conversation

cxbrowne1207
Copy link
Member

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/968
Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cxbrowne1207 cxbrowne1207 changed the title Add client process for CloudStack datacenter config Add client processor for CloudStack datacenter config Feb 21, 2023
@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2023
@cxbrowne1207 cxbrowne1207 marked this pull request as ready for review February 21, 2023 22:33
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #5032 (90474f7) into main (8d1dc2c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5032   +/-   ##
=======================================
  Coverage   71.98%   71.99%           
=======================================
  Files         419      419           
  Lines       34304    34315   +11     
=======================================
+ Hits        24694    24705   +11     
  Misses       8090     8090           
  Partials     1520     1520           
Impacted Files Coverage Δ
pkg/cluster/build.go 100.00% <100.00%> (ø)
pkg/cluster/cloudstack.go 64.70% <100.00%> (+6.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/cluster/cloudstack_test.go Outdated Show resolved Hide resolved
pkg/cluster/cloudstack_test.go Outdated Show resolved Hide resolved
pkg/cluster/cloudstack_test.go Outdated Show resolved Hide resolved
pkg/cluster/cloudstack_test.go Outdated Show resolved Hide resolved
pkg/cluster/cloudstack_test.go Outdated Show resolved Hide resolved
@cxbrowne1207 cxbrowne1207 force-pushed the cloudstack-client-processor-datacenter-config branch from f006e08 to 90474f7 Compare February 22, 2023 22:49
@cxbrowne1207
Copy link
Member Author

/test eks-anywhere-presubmit

@cxbrowne1207
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cxbrowne1207

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 9418b06 into aws:main Feb 22, 2023
@cxbrowne1207 cxbrowne1207 deleted the cloudstack-client-processor-datacenter-config branch February 22, 2023 23:46
raymond-zhang00 pushed a commit to raymond-zhang00/eks-anywhere that referenced this pull request Feb 27, 2023
@drewvanstone drewvanstone modified the milestone: v0.15.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants