-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate registry mirror config for Nutanix provider #5236
Propagate registry mirror config for Nutanix provider #5236
Conversation
Hi @thunderboltsid. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d21afdd
to
640fffc
Compare
640fffc
to
1f82423
Compare
1f82423
to
e1ba988
Compare
8e2103f
to
0c3cc06
Compare
Codecov Report
@@ Coverage Diff @@
## main #5236 +/- ##
==========================================
+ Coverage 72.18% 72.21% +0.03%
==========================================
Files 435 435
Lines 35469 35475 +6
==========================================
+ Hits 25602 25620 +18
+ Misses 8326 8315 -11
+ Partials 1541 1540 -1
... and 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@cxbrowne1207 Updated the PR with support for propagating of skipping TLS verification in the templates. Can you please take a look? |
3d62735
to
efca4ff
Compare
/assign @abhinavmpandey08 |
/ok-to-test |
d7d5359
to
037d3d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1796a41
to
ef09260
Compare
/assign @d8660091 |
@cxbrowne1207 had to update the PR to add some more unit tests to maintain coverage numbers. Can you PTAL? |
/lgtm Looks solid! |
test/e2e/nutanix_test.go
Outdated
@@ -775,3 +776,41 @@ func TestNutanixKubernetes126OIDC(t *testing.T) { | |||
) | |||
runOIDCFlow(test) | |||
} | |||
|
|||
// Registry Mirror Tests | |||
func TestNutanixKubernetes124UbuntuRegistryMirrorAndCert(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind moving the e2e to a separate PR? We will need to setup some infra for this which we don't have currently.
c8a88c1
to
da644bd
Compare
in registry mirror
ensure insecure skip verify is allowed for NutanixDatacenterKind.
These will be added in a separate PR.
da644bd
to
bbd5bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/woof
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To support EKS-Anywhere on Nutanix in air-gapped environments, we need to honor the
local registry mirror specified in the cluster config and propagate it forward.
How has this been tested?
Followed https://anywhere.eks.amazonaws.com/docs/reference/clusterspec/optional/registrymirror/ to set up a
harbor registry with necessary projects and importing the images to the harbor registry.
Add the
registryMirrorConfiguration
property to the cluster spec pointing to the new registry.Using a bundle-release.yaml with an image of the controller built from the changes in this PR as bundles override, create a cluster.