-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support linking VM resources with Projects on Nutanix #5266
Support linking VM resources with Projects on Nutanix #5266
Conversation
Hi @thunderboltsid. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2c4ab46
to
201aa96
Compare
/assign @abhinavmpandey08 |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## main #5266 +/- ##
==========================================
+ Coverage 72.39% 72.40% +0.01%
==========================================
Files 439 439
Lines 36047 36097 +50
==========================================
+ Hits 26095 26136 +41
- Misses 8386 8394 +8
- Partials 1566 1567 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
201aa96
to
9d7694e
Compare
Project links the Nutanix Machine resources to a Prism Central Project.
9d7694e
to
56afc4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/woof
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes allow specifying an optional project in the NutanixMachineConfig
which, when specified, is propagated to the corresponding NutanixMachineTemplate
property.
How has this been tested?
the ones corresponding to the changes in this PR.
project
property inNutanixMachineConfig
manifests tomy-project
: A project that already exists in Prism Centralmy-project
project.Full install logs: https://app.warp.dev/block/ZQ5t4rdhmUL0GCNQZ2JqNW